Strange: In my web server’s log file I can see the call for the album art for the Player view - but no log entries if I switch to the Album view (as if MAFA does not even try to fetch the images)
Can you please verify your MPD version?
0.16.0 is very old. It’s difficult to even build for testing.
I tested with a more recent MPD version and the HTTP album art works both in the player and the albums view. It doesn’t mean there’s no bug, but it would help to catch the problem if I could test with the same MPD version you are using.
I am a developer myself, please advise, how I can help
Why should the missing album images be related to the MPD version? I would have suggested, fetching images via HTTP from the server is independent from MPD
I use lighttpd as webserver
As already described in my first post: fetching album images via Firefox works, and gold old MPDroid also shows all images as expected
The best hint I can give are the missing log entries on my webserver: It looks as if no album images are requested in the Album view (in contrast to the Player view: there the album images are fetched, which is reflected in GET log entries on the webserver)
In order to query the cover art image file the client needs to know the path of the target music file.
In the player queue the path is given.
In the albums view, the client first queries for the album’s tracks and then uses the path of the first track.
In a recent MAFA version, the window 0:1 argument was added to the find album command.
This argument is supported since MPD v0.20.
MAFA does check the MPD version before using the window argument. That’s why the MPD version is important.
If MAFA uses this argument with an MPD that doesn’t support it, the command will fail and there will not be a query for the cover art.
Can you look in your MPD log to see if commands like: find album ALBUM_NAME window 0:1 are sent by MAFA and failing?
PS. you may need to clear or refresh the album art cache in order to force MAFA to retry failed album art attempts.
Alex, I have turned on MPD logging (log level “verbose”).
If I browse the Album view this is what is being logged:
...
Nov 03 19:08 : client: [1] process command list
Nov 03 19:08 : client: command_process_list: process command "count album "A Momentary Lapse of Reason""
Nov 03 19:08 : client: command_process_list: command returned 0
Nov 03 19:08 : client: command_process_list: process command "tagtypes clear"
Nov 03 19:08 : client: command_process_list: command returned -1
Nov 03 19:08 : client: [1] process command list returned -1
Nov 03 19:08 : client: [1] process command list
Nov 03 19:08 : client: command_process_list: process command "count album "A New Flame""
Nov 03 19:08 : client: command_process_list: command returned 0
Nov 03 19:08 : client: command_process_list: process command "tagtypes clear"
Nov 03 19:08 : client: command_process_list: command returned -1
Nov 03 19:08 : client: [1] process command list returned -1
...
This is not what you were looking for. What would I need to do, to increase the log level?
And this is the output if I browse to the Playlist view:
Nov 03 19:16 : client: [1] process command "idle"
Nov 03 19:16 : client: [1] command returned 1
Nov 03 19:16 : client: [1] process command "playlistinfo 0:20"
Nov 03 19:16 : client: [1] command returned 0
Nov 03 19:16 : client: [1] process command "playlistinfo 0:20"
Nov 03 19:16 : client: [1] command returned 0
Nov 03 19:16 : client: [1] process command "idle"
Nov 03 19:16 : client: [1] command returned 1
Looks like the problem is with the tagtypes clear command.
The MPD changelog is not detailed enough about what version exactly added the sub command clear. tagtypes was added in MPD v0.13, but the sub-command clear seems to be from v0.21 (2018).
I’ll have to look in the source history and make conditional use of this command according to protocol version. It may take some time.
(Just out of curiosity, why do you keep using such an old version of MPD?)
It works! I confirm that the bugfix (if you want to call it so, it is more like an old-version-feature-request) works and album art is working again.
Thanks for the great support, even on MPD versions from the stone age.
